slweb

чување 7ce37e14af081cd4f3269ad06b1ebd038755fa67
родитељ 3e9caff71d0ef0f8dcef9ef3c01da1f4831277d2
Аутор: Страхиња Радић <contact@strahinja.org>
Датум:   Thu, 16 May 2024 21:11:26 +0200

slweb.c: Fix a few instances of dead code and wrong types thanks to
LLVM's scan-build

Signed-off-by: Страхиња Радић <contact@strahinja.org>

Diffstat:
M
slweb.c
 | 
30
+++++++++++++-----------------

измењених датотека: 1, додавања: 13(+), брисања: 17(-)
diff --git a/slweb.c b/slweb.c
@@ -913,8 +913,7 @@ read_tsv(FILE* output, const char* filename, tsv_callback_t callback)
 
 	while (!feof(tsv) && (!tsv_iter || tsv_lineno <= tsv_iter))
 	{
-		u8* eol	   = NULL;
-		size_t res = 0;
+		u8* eol = NULL;
 		if (!fgets((char*)bufline, BUFSIZE, tsv))
 			break;
 		eol = (u8*)strchr((char*)bufline, '\n');
@@ -934,9 +933,8 @@ read_tsv(FILE* output, const char* filename, tsv_callback_t callback)
 			if (tsv_lineno > 0
 				&& current_register < MAX_TSV_REGISTERS)
 			{
-				if ((res = strlcpy((char*)tsv_register
-							   [current_register],
-					     (char*)token, BUFSIZE))
+				if (strlcpy((char*)tsv_register[current_register],
+					    (char*)token, BUFSIZE)
 					>= BUFSIZE)
 					warning(1, (u8*)"strlcpy:%d: Overflow",
 						__LINE__);
@@ -1042,7 +1040,7 @@ process_tsv(FILE* output, const u8* arg_token,
 			return 0;
 
 		tsv_iter = 0;
-		args = (u8*)strtok_r((char*)arg_token, " ", (char**)&saveptr);
+		(void)strtok_r((char*)arg_token, " ", (char**)&saveptr);
 		args = (u8*)strtok_r(NULL, " ", (char**)&saveptr);
 		if (!args)
 			exit(error(EINVAL,
@@ -1054,7 +1052,7 @@ process_tsv(FILE* output, const u8* arg_token,
 				(u8*)"process_tsv: First argument must be a"
 				     " string"));
 		if (!tsv_filename)
-			CALLOC(tsv_filename, u8, BUFSIZE);
+			CALLOC(tsv_filename, char, BUFSIZE);
 		args_base = (u8*)strdup((char*)args + 1);
 		*(args_base + strlen((char*)args_base) - 1) = 0;
 		snprintf(tsv_filename, BUFSIZE, "%s/%s.tsv", input_dirname,
@@ -1093,7 +1091,7 @@ process_tsv_count(FILE* output, const u8* arg_token,
 
 	tsv_iter = 0;
 
-	args = (u8*)strtok_r((char*)arg_token, " ", (char**)&saveptr);
+	(void)strtok_r((char*)arg_token, " ", (char**)&saveptr);
 	args = (u8*)strtok_r(NULL, " ", (char**)&saveptr);
 	if (!args)
 		exit(error(EINVAL, (u8*)"%csv-count: Arguments required",
@@ -1104,7 +1102,7 @@ process_tsv_count(FILE* output, const u8* arg_token,
 			(u8*)"%csv-count: First argument must be a string",
 			is_tsv ? 't' : 'c'));
 	if (!tsv_filename)
-		CALLOC(tsv_filename, u8, BUFSIZE);
+		CALLOC(tsv_filename, char, BUFSIZE);
 	args_base = (u8*)strdup((char*)args + 1);
 	*(args_base + strlen((char*)args_base) - 1) = 0;
 	snprintf(tsv_filename, BUFSIZE, "%s/%s.%csv", input_dirname,
@@ -1513,9 +1511,10 @@ process_csv(FILE* output, const u8* arg_token,
 
 		csv_iter    = 0;
 		u8* saveptr = NULL;
-		u8* args    = (u8*)strtok_r((char*)arg_token, " ",
-			   (char**)&saveptr);
-		args	    = (u8*)strtok_r(NULL, " ", (char**)&saveptr);
+		u8* args    = NULL;
+
+		(void)strtok_r((char*)arg_token, " ", (char**)&saveptr);
+		args = (u8*)strtok_r(NULL, " ", (char**)&saveptr);
 		if (!args)
 			exit(error(EINVAL,
 				(u8*)"process_csv: Arguments required"));
@@ -1525,7 +1524,7 @@ process_csv(FILE* output, const u8* arg_token,
 				(u8*)"process_csv: First argument must be a "
 				     "string"));
 		if (!csv_filename)
-			CALLOC(csv_filename, u8, BUFSIZE);
+			CALLOC(csv_filename, char, BUFSIZE);
 		u8* args_base = (u8*)strdup((char*)args + 1);
 		*(args_base + strlen((char*)args_base) - 1) = 0;
 		snprintf(csv_filename, BUFSIZE, "%s/%s.csv", input_dirname,
@@ -2048,7 +2047,7 @@ process_incdir(FILE* output, const u8* token, const u8* link_prefix,
 	if (read_yaml_macros_and_links)
 		return 0;
 
-	arg = (u8*)strtok_r((char*)token, " ", (char**)&saveptr);
+	(void)strtok_r((char*)token, " ", (char**)&saveptr);
 	arg = (u8*)strtok_r(NULL, " ", (char**)&saveptr);
 	if (!arg)
 		exit(error(1, (u8*)"process_incdir: Arguments required"));
@@ -5678,10 +5677,7 @@ main(const int argc, const char** argv)
 				else if (!strcmp(arg, "version"))
 					cmd = CMD_VERSION;
 				else if (!strcmp(arg, "body-only"))
-				{
-					arg += strlen("body-only");
 					body_only = 1;
-				}
 				else if (startswith(arg, "basedir"))
 				{
 					arg += strlen("basedir");